-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement /database
and /database/query
#1802
Conversation
@@ -33,6 +33,8 @@ | |||
public TreeEntry Matrix { get; private set; } | |||
public TreeEntry Exception { get; private set; } | |||
public TreeEntry Savefile { get; private set; } | |||
public TreeEntry Database { get; private set; } |
Check warning
Code scanning / InspectCode
Non-nullable member is uninitialized. Warning
@@ -33,6 +33,8 @@ | |||
public TreeEntry Matrix { get; private set; } | |||
public TreeEntry Exception { get; private set; } | |||
public TreeEntry Savefile { get; private set; } | |||
public TreeEntry Database { get; private set; } | |||
public TreeEntry DatabaseQuery { get; private set; } |
Check warning
Code scanning / InspectCode
Non-nullable member is uninitialized. Warning
@@ -21,6 +21,8 @@ | |||
public static readonly DreamPath World = new DreamPath("/world"); | |||
public static readonly DreamPath Client = new DreamPath("/client"); | |||
public static readonly DreamPath Datum = new DreamPath("/datum"); | |||
public static readonly DreamPath Database = new DreamPath("/database"); |
Check notice
Code scanning / InspectCode
Use preferred style of 'new' expression when created type is evident Note
@@ -21,6 +21,8 @@ | |||
public static readonly DreamPath World = new DreamPath("/world"); | |||
public static readonly DreamPath Client = new DreamPath("/client"); | |||
public static readonly DreamPath Datum = new DreamPath("/datum"); | |||
public static readonly DreamPath Database = new DreamPath("/database"); | |||
public static readonly DreamPath DatabaseQuery = new DreamPath("/database/query"); |
Check notice
Code scanning / InspectCode
Use preferred style of 'new' expression when created type is evident Note
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
hopefully! this probably needs work and a more comprehensive test suite -
/database/query/Reset()
isn't implemented because it seems a real ass